Support servant-server-0.19.1 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @nbacquey, Did you try running the test suite for this? I patched the library for the same during upgrading a project and it builds, but when you run the tests for this, they fail. |
Since version 0.19.1, `servant-server` requires the type `a` in combinator `Capture foo a` to be `Typeable`. This commit adds the constraint in `HasMock` for `Capture'` and `CaptureAll`
nbacquey
force-pushed
the
support_servant_0.19
branch
from
33de01d to
6b2398f
Compare
|
This later version should work, the test suite passes. |
|
We're using this, any chance to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 0.19.1,
servant-serverrequires the typeain combinatorCapture foo ato beTypeable. This commit adds the constraint inHasMockforCapture'andCaptureAll